Add a test verifying only JWT introspection can be used and update the docs #17953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
force-pushed
the
oidc_jwt_introspection
branch
from
e3ce4d5 to
2cb1937
Compare
|
@gastaldi Can you please consider reviewing this PR ? Pedro may be a bit busy - here only a test added and docs updated and some log statements are added (just now to let users see why the introspection has failed), no real OIDC code updates - I'd consider adding a new property (see the description) later if someone requests it. |
|
@gastaldi thanks |
|
@pedroigor I think we are OK here - the introspection can be easily forced for JWT tokens issued from KC - we can certainly add a new property if ever required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test verifying that the JWT introspection only can be forced and updated the docs with a new sub section about controlling the verification and introspection processes in the
servicedocs; also removed the small section about the introspection only I added with one of the latest PRs (I found it was mostly repeating what was said in other sub sections) and updated the newly added section with the info aboutTokenIntrospectioninjection.@pedroigor Hi Pedro, how does it look to you ? The only minor concern is that the JWT introspection is forced indirectly (by configuring the introspection path only) but I was hesitant to introduce a new property (
force-jwt-introspectionetc) since we already haveallow-jwt-introspection(so that the users can set this property to false and disable the introspection).I suppose we can add
force-jwt-introspectionas well and doc that in this caseallow-jwt-introspectionproperty will be ignored. However in case of Keycloak it is very easy to point to the introspection endpoint. So probably we can avoid adding a new property for now and addforce-jwt-introspectionif it will be hard to find out for some other providers the address of this endpoint so that it can be auto-discovered...Let me know what you prefer please